-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#384 Initial Changes for confirmation #393
base: main
Are you sure you want to change the base?
#384 Initial Changes for confirmation #393
Conversation
Hey @Scooletz do these changes look good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really promising 🙂
Some test could be added to ensure that the tree is properly rolled up and the pages are reused. Like: writing a big tree in one block, removing in other, spinning one block to make them reusable and reuse again.
Scheduled a run for GH workflow and added some remarks that should improve the logic.
Co-authored-by: Szymon Kulec <[email protected]>
Hi @Scooletz , i made the suggested fix in the NullPage declaration. Will work on the test cases like you suggested. |
Hey @Scooletz , I couldn't pick it up earlier due to other work. Resuming it now. Can you kindly help me with existing code references to write these test cases? I looked over the PagedDbTests.cs and existing DeleteByPrefix test methods. But I think what you described requires a different approach. |
Resolves #384
List of Changes -
Pending Changes -
Recursively calling for child pages (if the prefix is empty) - need help here.