Slotted array faster defragmentation #364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
SlottedArray.Defragment
method that is clearly visible in traces and previously was copying data twice, once from the array to a buffer, then buffer to an array. This PR removes the need of the auxiliary buffer which required renting & releasing but also introduced one more copy.The benchmarks below does not show the gains that are observed. P95 of the block application to the database dropped by ~20% which is a lot.
Benchmark
Before
After