Add more detailed comment for clearing the last nibble for odd-len NibblePath #353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This portion of
WriteImpl
was doing an operation which was difficult to understand at first glance and needed a more detailed comment to explain.Reference :-
If the sum of odd and length is odd, the function clears the lower nibble of the last byte in the written path.
ref var oldest = ref destination[spanLength];
gets a reference to the byte at position spanLength in the destination buffer.
oldest = (byte)(oldest & 0b1111_0000);
clears the lower nibble of this byte by performing a bitwise AND with 0b1111_0000 (which is 0xF0).