Added constant for single byte prefix content length in RLP

NethermindEth · Sep 18, 2024 · f4da5bc · f4da5bc
1 parent 2206fa9
commit f4da5bc
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/Paprika/Merkle/ComputeMerkleBehavior.cs b/src/Paprika/Merkle/ComputeMerkleBehavior.cs
@@ -650,7 +650,7 @@ private void EncodeBranch(scoped in Key key, scoped in ComputeContext ctx, scope
         var end = stream.Position;
         var actualLength = end - initialShift;
         var lengthOfLength = Rlp.LengthOfLength(actualLength);
-        if (actualLength >= 56) //to match StartSequence
+        if (actualLength >= Rlp.SmallPrefixBarrier) //to match StartSequence
             lengthOfLength++;
         var from = initialShift - lengthOfLength;
         stream.Position = from;

diff --git a/src/Paprika/RLP/Rlp.cs b/src/Paprika/RLP/Rlp.cs
@@ -11,6 +11,7 @@ public static class Rlp
 {
     public const int LengthOfKeccakRlp = 33;
     public const int MaxLengthOfLength = 4;
+    public const int SmallPrefixBarrier = 56;
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static int LengthOf(in UInt256 item)
@@ -47,7 +48,7 @@ public static int LengthOf(ReadOnlySpan<byte> span)
             return 1;
         }
 
-        if (span.Length < 56)
+        if (span.Length < SmallPrefixBarrier)
         {
             return span.Length + 1;
         }
@@ -57,7 +58,7 @@ public static int LengthOf(ReadOnlySpan<byte> span)
 
     public static int LengthOfSequence(int contentLength)
     {
-        if (contentLength < 56)
+        if (contentLength < SmallPrefixBarrier)
         {
             return 1 + contentLength;
         }

diff --git a/src/Paprika/RLP/RlpStream.cs b/src/Paprika/RLP/RlpStream.cs
@@ -24,7 +24,7 @@ public RlpStream(Span<byte> data)
 
     public void StartSequence(int contentLength)
     {
-        if (contentLength < 56)
+        if (contentLength < Rlp.SmallPrefixBarrier)
         {
             byte prefix = (byte)(192 + contentLength);
             WriteByte(prefix);
@@ -72,7 +72,7 @@ public void Encode(scoped ReadOnlySpan<byte> input)
         {
             WriteByte(input[0]);
         }
-        else if (input.Length < 56)
+        else if (input.Length < Rlp.SmallPrefixBarrier)
         {
             byte smallPrefix = (byte)(input.Length + 128);
             WriteByte(smallPrefix);