Prefetching for Report in pages (#350)

NethermindEth · Jun 10, 2024 · a22ab75 · a22ab75
1 parent fd332bb
commit a22ab75
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 2 deletions.
diff --git a/src/Paprika/Store/DataPage.cs b/src/Paprika/Store/DataPage.cs
@@ -303,6 +303,11 @@ private static bool TryGet(IReadOnlyBatchContext batch, scoped in NibblePath key
 
     public void Report(IReporter reporter, IPageResolver resolver, int pageLevel, int trimmedNibbles)
     {
+        resolver.Prefetch(Data.Buckets);
+
+        var slotted = new SlottedArray(Data.DataSpan);
+        reporter.ReportDataUsage(Header.PageType, pageLevel, trimmedNibbles, slotted);
+
         foreach (var bucket in Data.Buckets)
         {
             if (!bucket.IsNull)
@@ -315,8 +320,7 @@ public void Report(IReporter reporter, IPageResolver resolver, int pageLevel, in
             }
         }
 
-        var slotted = new SlottedArray(Data.DataSpan);
-        reporter.ReportDataUsage(Header.PageType, pageLevel, trimmedNibbles, slotted);
+
     }
 
     public void Accept(IPageVisitor visitor, IPageResolver resolver, DbAddress addr)

diff --git a/src/Paprika/Store/IBatchContext.cs b/src/Paprika/Store/IBatchContext.cs
@@ -145,5 +145,17 @@ public interface IPageResolver
     /// Gets the page at given address.
     /// </summary>
     Page GetAt(DbAddress address);
+
     void Prefetch(DbAddress address);
+
+    void Prefetch(ReadOnlySpan<DbAddress> addresses)
+    {
+        foreach (var bucket in addresses)
+        {
+            if (!bucket.IsNull)
+            {
+                Prefetch(bucket);
+            }
+        }
+    }
 }
diff --git a/src/Paprika/Store/LeafPage.cs b/src/Paprika/Store/LeafPage.cs
@@ -294,6 +294,8 @@ public void Report(IReporter reporter, IPageResolver resolver, int pageLevel, in
 
     public void Accept(IPageVisitor visitor, IPageResolver resolver, DbAddress addr)
     {
+        resolver.Prefetch(Data.Buckets);
+
         using var scope = visitor.On(this, addr);
 
         foreach (var bucket in Data.Buckets)

diff --git a/src/Paprika/Store/StorageFanOutPage.cs b/src/Paprika/Store/StorageFanOutPage.cs
@@ -108,6 +108,8 @@ public void Report(IReporter reporter, IPageResolver resolver, int pageLevel, in
 
     public void Accept(IPageVisitor visitor, IPageResolver resolver, DbAddress addr)
     {
+        resolver.Prefetch(Data.Addresses);
+
         using var scope = visitor.On(this, addr);
 
         foreach (var bucket in Data.Addresses)