forked from Azure/DotNetty
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for packaging #4
Open
rubo
wants to merge
23
commits into
dev
Choose a base branch
from
feature/packaging
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [0.7.2] Start threads as background in HashedWheelTimer, LoopExecutor, ThreadDeathWatcher * + code formatting * [0.7.3] Target net5 and net6 (#2) target net5 and net6 Adopted TlsHandler for the case when Handshake completion callback is dispatched asynchronously to thread pool Introduced SingleThreadedEmbededChannel for TlsHandler and SniHandler tests * + Update DotNetVersion to "6.0.302" in build.ps1
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
shouldn't we bring these changes in two PRs? |
@tanishqjasoria I don't see any necessity of splitting it into multiple PR's. It's a rebase. |
Fix infinite loop caused by disconnection during TLS handshake, and the memory exploded instantly.
+ Fix infinite loop caused by TlsHandler
fixed Contribution Guide link. Same link as the next page. https://github.com/Azure/azure-powershell/blob/main/README.md
Added try-catch block while starting the watcherThread in ThreadDeath…
rubo
force-pushed
the
feature/packaging
branch
from
October 21, 2022 13:12
35f0670
to
31eed7c
Compare
rubo
force-pushed
the
feature/packaging
branch
from
October 21, 2022 13:25
31eed7c
to
43ff957
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configured and updated package info. In
.csproj
files, replaced tags have been commented out instead of deleted to mitigate future merge conflicts.This branch has been rebased on the latest
upstream/dev
, bringing the v0.7.4 changes from Microsoft. Those changes mostly contain build and packaging-related material, so better have them now to avoid potential merge conflicts in the future. Thus, this branch should be force-pushed todev
.