Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: multiple fixes on update #819

Merged
merged 3 commits into from
Feb 28, 2025
Merged

metrics: multiple fixes on update #819

merged 3 commits into from
Feb 28, 2025

Conversation

gsanchietti
Copy link
Member

@gsanchietti gsanchietti commented Feb 28, 2025

This PR tries to prevent existing race conditions:

  • make sure node-monitor is really stopped
  • stop node_exporter existing instances before starting new ones
  • make node_exporter systemd unit more tolerant to errors

NethServer/dev#7162

@gsanchietti gsanchietti self-assigned this Feb 28, 2025
Changes:
- wait a bit more on restart: prevent failure if the port 9100 is
  already occupied by an old instance of node_exporting that is taking
  too much time stop
- exit with 0 on normal shutdown
@gsanchietti gsanchietti force-pushed the fixes_alertmanager branch 3 times, most recently from 4bd0ebc to 7eab638 Compare February 28, 2025 09:51
Try to prevent this error on some machines:

 Failed to disable unit: Unit file node-monitor.service does not exist.

The error is likely caused by a race condition
@gsanchietti gsanchietti marked this pull request as ready for review February 28, 2025 10:08
@gsanchietti gsanchietti merged commit 3840c56 into main Feb 28, 2025
2 checks passed
@gsanchietti gsanchietti deleted the fixes_alertmanager branch February 28, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants