Add image core and app version constraint checks #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for the following image labels: - org.nethserver.min-core - org.nethserver.min-from
Get the list of available core module updates from list_modules() to enforce org.nethserver.min-core label requirement.
The image_url must be a good update for all instances passed as parameter. As it is difficult to check if it is appropriate or not, or to calculate an image_url that fits all instances (if not given), we drop the automatic latest version lookup and we expect a good one is passed.
- ui. Update a list of instances with update-modules. - api. add filter parameters to update-modules, to restrict the update to certain instances and module types. This action can now be used to replace update-module if an automatic version selection is wanted.
The logic that defines the "latest" tag of a given module is implemented inside the list_available() function. A new assumption simplifies the function code.
- calculate core versions update for every cluster node, not only leader - fix install-core.sh to initialize IMAGE_URL and related variables in node environment
Compare the app requirement min-core with the core version installed on the app's node. Previously the leader version was used.
Tbaile
approved these changes
Jul 12, 2024
|
Wow, this will solve so many problem. looking forward to this in a future release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement module image labels
org.nethserver.min-fromorg.nethserver.min-coreSee changes to
modules.md.Implementation summary:
min-corecheck is based on the node version where the app is installedmin-fromlabel 1cluster/module_nodeis authoritative to get the list of installed modules and cluster node IDslist_installed_core()has been merged within list_core_modules()Affected actions:
Fixed install-core.sh
Refs NethServer/dev#6956
Footnotes
list_available() already returns in versions[0] the higher repository semver tag of the app ↩