-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud Log Manager and Syslog forwarders #652
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andre8244
requested changes
Jun 26, 2024
core/ui/src/components/settings/CloudLogManagerConfigureModal.vue
Outdated
Show resolved
Hide resolved
core/ui/src/components/settings/CloudLogManagerConfigureModal.vue
Outdated
Show resolved
Hide resolved
b51c3b7
to
917dff4
Compare
- New modals on active loki cards - New card on cluster status - Some other fix
917dff4
to
61a3661
Compare
61a3661
to
adc0227
Compare
andre8244
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's set notification description too, then we should be good
core/ui/src/components/settings/CloudLogManagerConfigureModal.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrea Leardini <[email protected]>
andre8244
approved these changes
Jul 1, 2024
Co-authored-by: Andrea Leardini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI parts:
Actions:
list-loki-istances
apiNethServer/dev#6932