Update core procedure enhancements #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidePrincipi
force-pushed
the
feat-core-update
branch
from
e74e790 to
7388a82
Compare
DavidePrincipi
force-pushed
the
feat-core-update
branch
from
7388a82 to
5a507ad
Compare
Refreshing granted actions on node is no longer required as the api-server understands glob-patterns since beta 1 release at least.
Update core modules after successfully installing the new core image on every node.
The last command has always exit code 0, because we are in a IF branch.
Correctly implement the cluster grant updates under the cluster environment. The existing script under the node agent is retained to avoid breaking upgrades from B2 and RC1 installations.
DavidePrincipi
force-pushed
the
feat-core-update
branch
from
5a507ad to
04f3e92
Compare
The flag introduced for update-module is implemented for update-core too and has effect on the update-module sub-tasks started to update core modules.
DavidePrincipi
force-pushed
the
feat-core-update
branch
from
04f3e92 to
7093491
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the update-core procedure to install the new core image before starting update of core modules. This is important to receive core updates that install fixes to Python libraries or execute Redis updates before any core module is updated.
For this purpose two new directories are defined and can be filled with helper scripts (commands):
update-core-pre-modules.d/update-core-post-modules.d/Failed scripts do not abort the update-core action. Such scripts are important because they are executed from the new core image, whilst action steps are executed from the old core image, at least until step
50update_core.50update_coreare executed from the new image.The PR also implements a
forceflag in the update-core action, like the similar flag already implemented for update-module. The effect of passingforce:trueis propagated to update-module sub-tasks started to update core modules, too.See also Updates in dev's manual page.