Skip to content

Commit

Permalink
Fix semver comparison (#714)
Browse files Browse the repository at this point in the history
Comparison between strings is wrong: use the semver variable instead.

NethServer/dev#7040
  • Loading branch information
DavidePrincipi authored Sep 27, 2024
1 parent 9380bb8 commit 29729cb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/imageroot/usr/local/agent/pypkg/cluster/modules.py
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ def _calc_update(image_name, cur):
try:
vupdate = module["versions"][0]['tag']
vinfo = semver.VersionInfo.parse(vupdate)
if vupdate > cur:
if vinfo > cur:
return vupdate
except:
pass
Expand Down

0 comments on commit 29729cb

Please sign in to comment.