Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow migration of account provider with "not_available" status #86

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Allow migration of account provider with "not_available" status #86

merged 2 commits into from
Sep 26, 2024

Conversation

stephdl
Copy link
Contributor

@stephdl stephdl commented Sep 25, 2024 •
edited
Loading

This pull request enables

  • the migration of the account provider even if it has a "not_available" status. Previously, the migration was only allowed for certain statuses, but now it can be performed regardless of the status.
  • It prevents migrating the account provider before the Netvoice app.

NethServer/dev#7037

@nethbot
Copy link
Member

nethbot commented Sep 25, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.16-1.3.pr86.g89ad397.ns7.x86_64.rpm x86_64

DavidePrincipi
DavidePrincipi approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@DavidePrincipi DavidePrincipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nethbot
Copy link
Member

nethbot commented Sep 26, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.16-1.4.pr86.g111f906.ns7.x86_64.rpm x86_64

@stephdl stephdl merged commit cf4bbf9 into master Sep 26, 2024
1 check passed
@stephdl stephdl deleted the sdl_fix_migration_disabled_apps branch September 26, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidePrincipi DavidePrincipi DavidePrincipi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephdl @nethbot @DavidePrincipi