fix(migration): handle truncated wan #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tbaile
approved these changes
Feb 14, 2025
Avoid the following error when there is a conflict of names:
Traceback (most recent call last):
File "/usr/share/ns-migration/20wan", line 89, in <module>
mwan.store_policy(u, f'{pname[0:6]}_only', [i])
File "/usr/lib/python3.11/site-packages/nethsec/mwan/__init__.py", line 257, in store_policy
nethsec.utils.ValidationError: ('name', 'unique', 'timene_only')
Before the commit, if a network was truncated to 15 chars, the new short name
was used inside the `network` config database but not inside the
`firewall` database: the firewall zone was pointing to a non existing
network,
Example:
- original name of the interface was 'timenet_ftth_12345'
- value saved inside the network db:
config interface 'timenet_ftth_1'
option proto 'static'
- value saved inside 'firewall' db:
config zone 'ns_wan'
option name 'wan'
option output 'ACCEPT'
option input 'DROP'
option forward 'REJECT'
list network 'timenet_ftth_12345'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1067