Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core module update 2.10+ ignored #7040

Open
DavidePrincipi opened this issue Sep 26, 2024 · 4 comments
Open

Core module update 2.10+ ignored #7040

DavidePrincipi opened this issue Sep 26, 2024 · 4 comments
Assignees
@DavidePrincipi
Labels
bug A defect of the software verified All test cases were verified successfully

Comments

@DavidePrincipi
Copy link
Member

Starting from core version 2.10, updates are ignored.

Steps to reproduce

  • Install NS8 with core 2.9.4
  • Enable Testing for the default repository

Expected behavior

The update to core 2.10.0-dev.1 is offered.

Actual behavior

No update is found.

Components

  • Core 2.9.4

See also

Refs #6956 (feat-sci)
@DavidePrincipi DavidePrincipi added the bug A defect of the software label Sep 26, 2024
@DavidePrincipi DavidePrincipi self-assigned this Sep 26, 2024
@DavidePrincipi DavidePrincipi mentioned this issue Sep 26, 2024
Merged
DavidePrincipi added a commit to NethServer/ns8-core that referenced this issue Sep 27, 2024
@DavidePrincipi
Fix semver comparison (#714)
29729cb 
Comparison between strings is wrong: use the semver variable instead.

NethServer/dev#7040
@DavidePrincipi DavidePrincipi added the verified All test cases were verified successfully label Sep 27, 2024
@DavidePrincipi
Copy link
Member Author

Released in
https://github.com/NethServer/ns8-core/releases/tag/2.9.5

@DavidePrincipi DavidePrincipi mentioned this issue Oct 1, 2024
Closed
@DavidePrincipi
Copy link
Member Author

DavidePrincipi commented Oct 1, 2024 •
edited
Loading

Now that 2.10 is in repodata.json, the bug is back. The fix released with 2.9.5 is correct, but uneffective.

@DavidePrincipi DavidePrincipi reopened this Oct 1, 2024
@DavidePrincipi DavidePrincipi removed the verified All test cases were verified successfully label Oct 1, 2024
@DavidePrincipi DavidePrincipi mentioned this issue Oct 1, 2024
Merged
DavidePrincipi added a commit to NethServer/ns8-core that referenced this issue Oct 1, 2024
@DavidePrincipi
Assume versions are not sorted (#720)
4ecdd0d 
- Replace the previous function which expects a sorted array of versions
  where index 0 is the max tag value.
- Search the update by looking at the max Semver tag among all available
  versions.

Refs NethServer/dev#7040
@DavidePrincipi DavidePrincipi added the verified All test cases were verified successfully label Oct 1, 2024
@DavidePrincipi
Copy link
Member Author

Released https://github.com/NethServer/ns8-core/releases/tag/2.9.6

@DavidePrincipi
Copy link
Member Author

The second fix is still ineffective because the order of the versions array is not preserved. Items are sorted by their semver value, and the first item of the array is always 2.10. As a result, installations with core 2.9.4 still consider the largest value, 2.10, as a downgrade due to string comparison with 2.9.

We can resolve this deadlock by releasing version 3.0.0.

@DavidePrincipi DavidePrincipi reopened this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavidePrincipi DavidePrincipi

Labels
bug A defect of the software verified All test cases were verified successfully
Projects
NethServer
Status: New
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DavidePrincipi