Track if proxy protocol messages need buffering #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguerra
requested review from
sullis,
gavinbunney,
argha-c,
kyagna and
lindseyreynolds
gavinbunney
reviewed
Oct 20, 2023
| .attr(SourceAddressChannelHandler.ATTR_SERVER_LOCAL_PORT) | ||
| .get(); | ||
|
|
||
| String needsMoreData = haProxyState == ProtocolDetectionState.NEEDS_MORE_DATA ? "true" : "false"; |
There was a problem hiding this comment.
nit:
String needsMoreData = String.valueOf(haProxyState == ProtocolDetectionState.NEEDS_MORE_DATA);
There was a problem hiding this comment.
Or better yet, also move it into the registry.counter
sullis
approved these changes
Oct 20, 2023
lindseyreynolds
approved these changes
Oct 20, 2023
gavinbunney
approved these changes
Oct 20, 2023
kyagna
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.