Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to get all entries from push conn registry #1667

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

kyagna
Copy link
Contributor

@kyagna kyagna commented Oct 20, 2023

Change adds a new API/method to retrieve all entries from the push connection registry. The returned list represents a snapshot of the map as it was when the call was made.

@kyagna kyagna requested a review from AlexanderEllis October 20, 2023 04:32
@kyagna kyagna force-pushed the kyagna/conn-registry-getall branch from f74aa03 to e546809 Compare October 20, 2023 05:25
@kyagna kyagna force-pushed the kyagna/conn-registry-getall branch from e546809 to 1856a30 Compare October 20, 2023 05:32
Copy link
Contributor

@AlexanderEllis AlexanderEllis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for adding a test as well!

@kyagna kyagna merged commit 7c0fab9 into master Oct 20, 2023
7 checks passed
@kyagna kyagna deleted the kyagna/conn-registry-getall branch October 20, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants