Prepare for 2.x interface. #206
Conversation
theengineear
force-pushed
the
ready-2x-interface
branch
from
e0a5e14
to
1533347
Compare
| it('can change from unsafeHtml to null content', () => run(toUnsafeHTML, toNullContent)); | ||
| it('can change from unsafeHtml to text content', () => run(toUnsafeHTML, toTextContent)); | ||
| it('can change from unsafeHtml to array content', () => run(toUnsafeHTML, toArrayContent)); | ||
| it('can change from unsafeHtml to map', () => run(toUnsafeHTML, toMap)); |
There was a problem hiding this comment.
Took me longer than I‘d like to admit to figure out how to write expressive tests for this. I settled on this format, which feels pretty readable to me. Pretty happy with how this turned out – I ended up catching / fixing quite a few edge-case bugs. For example, previously if you bound unsafeHTML(/* stuff */) to some content and then bound null to that same content — the prior html didn’t actually get cleared for [reasons].
This should (at least minimally) test every possible content transition that we have today.
x-element.js
Outdated
| } | ||
| } | ||
|
|
||
| static #resetIfRequired(node, startNode, value, lastValue, context, lastContext) { |
There was a problem hiding this comment.
In case you’re curious — this function fixes a bunch of nuanced edge cases surrounding the transition from binding one kind of content value to another.
theengineear
force-pushed
the
ready-2x-interface
branch
2 times, most recently
from
dfb8e29
to
886d26b
Compare
Changes: * Adding `??attr` binding syntax. * Changing `ifDefined` to delete attr on `null` as well as `undefined`. * Deprecating `ifDefined` / `nullish` in favor of `??attr` binding. * Deprecating `repeat` in favor of `map`. * Updating documentation. Closes #204.
theengineear
force-pushed
the
ready-2x-interface
branch
from
886d26b
to
7f7e8ed
Compare
Changes:
??attrbinding syntax.ifDefinedto delete attr onnullas well asundefined.ifDefined/nullishin favor of??attrbinding.repeatin favor ofmap.Closes #204.