Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding IMSC 1.1 profile designators #344

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Adding IMSC 1.1 profile designators #344

merged 5 commits into from
Oct 25, 2024

Conversation

IMFTool
Copy link
Contributor

@IMFTool IMFTool commented Mar 20, 2023 •
edited by palemieux
Loading

Also includes the Netflix IMSC 1.1 Text Profile designator.

Closes #283

@IMFTool
Copy link
Contributor Author

IMFTool commented Mar 21, 2023

12fa94b
Is about adding IMSC 1.1 profile designators.
Currently Photon only accepts the two IMSC 1.0.1 profile designators.

900c972
The EssenceType is a Track File property, determined based on the EssenceDescriptor.
All timed text track files are “Data Essence”.
The SequenceType in turn is a CPL property, determined by the respective Virtual Track.
Subtitles, Karaoke etc. only exist as SequenceType, not as EssenceType.

@IMFTool IMFTool mentioned this pull request Oct 24, 2024
Closed
fschleich
fschleich approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@fschleich fschleich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fschleich fschleich merged commit 16933c9 into Netflix:master Oct 25, 2024
1 check passed
@IMFTool IMFTool deleted the wr-patch branch October 25, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschleich fschleich fschleich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IMSC 1.1 profiles missing
2 participants
@IMFTool @fschleich