serialize artifacts with pickle protocol 4 if possible #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amerberg
changed the title
romain-intel
previously approved these changes
Feb 6, 2025
There was a problem hiding this comment.
LGTM. I'll let @saikonen take a look as well but I think we can merge this.
|
Testing[4148896] @ b41f37c |
|
Testing[970] @ b41f37c had 2 FAILUREs. |
Is this different from the tests in the "checks" section, which all appear to have passed? If so, is there a way to see the failures? |
|
The tests are internal tests we run (since we also use the OSS version). The 2 failures are flaky tests. This is good to go for me. |
romain-intel
approved these changes
Feb 7, 2025
saikonen
approved these changes
Feb 7, 2025
talsperre
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the artifact serialization to to save with protocol 4 if available. Currently, artifacts are serialized with protocol 2, unless protocol 2 fails due to the size of the artifact, in which case protocol 4 is used. This PR updates the
TaskDatastoreto use protocol 4 if available, and otherwise attempt protocol 2.Protocol 4 was introduced in Python 3.4, which was released more than 10 years ago, and Metaflow's
setup.pyscript identifies Python 3.6 as the earliest supported version, so this change should not cause problems for users today. This leaves artifact loading unchanged.Using protocol 4 by default has a number of advantages:
I have successfully tested these changes on a simple flow with a large artifact using Python 3.13 on Argo Workflows.