Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify _enrich_object deployer method to set instance attributes #2052

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Modify _enrich_object deployer method to set instance attributes #2052

merged 1 commit into from
Sep 26, 2024

Conversation

talsperre
Copy link
Collaborator

The _enrich_object method currently sets attributes at a class level.

  • If we have multiple instances of a TriggeredRun or DeployedFlow in a script/notebook, then using _enrich_object to add/set an attribute like url to a TriggeredRun instance, would modify it for all the instances.
  • We might want a behavior where these attributes are set at an instance level, just like the methods are being set currently.

@romain-intel romain-intel merged commit cd9df22 into master Sep 26, 2024
26 checks passed
@romain-intel romain-intel deleted the dev/deployer-attribute-update branch September 26, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talsperre @romain-intel