Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready for Review] Update deployer API to support more orchestrators #2010

Merged
merged 3 commits into from
Sep 13, 2024
Merged

[Ready for Review] Update deployer API to support more orchestrators #2010

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d0b89f
Update deployer API to support more orchestrators
talsperre Sep 3, 2024
588177e
Rebase and update docstring
talsperre Sep 9, 2024
9249b0f
Address comments
romain-intel Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions metaflow/runner/deployer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ def handle_timeout(
Temporary file that stores runner attribute data.
command_obj : CommandManager
Command manager object that encapsulates the running command details.
file_read_timeout : int
Timeout for reading the file.

Returns
-------
Expand Down Expand Up @@ -397,6 +399,7 @@ def create(self, **kwargs) -> DeployedFlow:
self.name = content.get("name")
self.flow_name = content.get("flow_name")
self.metadata = content.get("metadata")
self.additional_metadata = content.get("additional_metadata", {})

if command_obj.process.returncode == 0:
deployed_flow = DeployedFlow(deployer=self)
Expand Down
Loading