-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support git dependencies with pip #1559
Conversation
6c590d0
to
7c8a405
Compare
de5cdfa
to
7ed6ebf
Compare
812d7bf
to
758641d
Compare
this seems to be running into issues with some repositories where a specific f.ex. with
|
fixed original issue by applying As an example:
saves as
saves as |
b821e9f
to
7991244
Compare
for context: |
4bd0a8b
to
d5bc7a8
Compare
So this builds when installing correct? In other words, it doesn't build during env resolution but during env hydration? Is that correct? If so, as I mentioned previously, I think this potentially breaks reproducibility. I may have missed the part though where it builds when resolving. |
This shouldn't break reproducibility as for non-wheel sources, specifically VCS, as a wheel will try to be built before reaching The intended flow is as follows for pypi env resolution:
|
metaflow/plugins/pypi/pip.py
Outdated
def _verify_wheel_tags_supported(wheel_name): | ||
target_tags = pip_tags(python, platform) | ||
built_tags = tags_from_wheel_name(wheel_name) | ||
if built_tags not in target_tags: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is quite correct. You probably want a set intersection and if empty, then error out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! Fixed this and added some unit tests for validation. Coverage is not extensive but should at least handle obvious cross-platform deployment breaks (e.g. osx-arm64
-> linux-64
)
superseded by #1681 |
Support for git repo dependencies.