Skip to content

Commit

Permalink
Add params to connect to zipkin tracing platform
Browse files Browse the repository at this point in the history
  • Loading branch information
darinyu committed Nov 13, 2023
1 parent 5ece011 commit 847b377
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions metaflow/runtime.py
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,13 @@ def execute(self):
"Workflow starting (run-id %s):" % self._run_id, system_msg=True
)

if TRACING_URL_TEMPLATE and tracing.get_trace_id():
tracing_url = TRACING_URL_TEMPLATE.format(trace_id=tracing.get_trace_id())
self._logger(
"Tracing URL will appear in the following %s. " % tracing_url,
system_msg=True,
)

self._metadata.start_run_heartbeat(self._flow.name, self._run_id)

if self._params_task:
Expand Down Expand Up @@ -309,13 +316,7 @@ def execute(self):
system_msg=True,
)
else:
self._logger("Done!", system_msg=True)
if TRACING_URL_TEMPLATE and tracing.get_trace_id():
tracing_log_template = "Tracing URL is %s" % TRACING_URL_TEMPLATE
self._logger(
tracing_log_template.format(trace_id=tracing.get_trace_id()),
system_msg=True,
)
self._logger("Done!", system_msg=True)
elif self._clone_only:
self._logger(
"Clone-only resume complete -- only previously successful steps were "
Expand Down

0 comments on commit 847b377

Please sign in to comment.