Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jdk migration of mantis-common to compile on JDK 17 #390

Closed
wants to merge 2 commits into from
Closed

Jdk migration of mantis-common to compile on JDK 17 #390

wants to merge 2 commits into from

Conversation

Adithya2907
Copy link

Context

Upgrade JDK version to 17. This PR upgrades the mantis-common module.
Part of #355

  • ../gradlew build in the mantis-common module fails org.mockito.exceptions.base.MockitoException at OperatorGroupByTest.java:1039 Caused by: java.lang.reflect.InaccessibleObjectException at OperatorGroupByTest.java error.
  • The reason for the error is using a version of the Mockito package not supported by JDK 17.
  • Therefore, updated the dependency from 2.0.+ to 2.23.4 which solves this problem.

Attaching screenshot of success build of the mantis-common module using JDK 17.
image

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable

Copy link
Collaborator

@Andyz26 Andyz26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would prefer handling the Java version as a whole instead of a single module level. Please do not pursue such a change for now as this requires more compatibility validation coordination.

@hmitnflx hmitnflx had a problem deploying to Integrate Pull Request September 5, 2023 20:25 — with GitHub Actions Failure
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Test Results

128 files  ±0  128 suites  ±0   8m 6s ⏱️ -57s
543 tests ±0  535 ✔️ +1  8 💤 ±0  0  - 1 
543 runs   - 1  535 ✔️ ±0  8 💤 ±0  0  - 1 

Results for commit d58d3a2. ± Comparison against base commit 867913f.

@Adithya2907 Adithya2907 closed this by deleting the head repository May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants