fix

Netflix · Oct 25, 2024 · 13bf442 · 13bf442
1 parent 585a349
commit 13bf442
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/.../java/com/netflix/hollow/core/write/objectmapper/flatrecords/FlatRecordOrdinalReader.java b/.../java/com/netflix/hollow/core/write/objectmapper/flatrecords/FlatRecordOrdinalReader.java
@@ -207,11 +207,12 @@ public Boolean readFieldBoolean(int ordinal, String field) {
   }
 
   public Boolean readFieldBoolean(Offset offset) {
-    offset.increment(1);
     if (VarInt.readVNull(record.data, offset.get())) {
+      offset.increment(1);
       return null;
     }
     int value = record.data.get(offset.get());
+    offset.increment(1);
     return value == 1 ? Boolean.TRUE : Boolean.FALSE;
   }
 
@@ -272,8 +273,8 @@ public float readFieldFloat(int ordinal, String field) {
   }
 
   public float readFieldFloat(Offset offset) {
-    offset.increment(4);
     int value = record.data.readIntBits(offset.get());
+    offset.increment(4);
     if (value == HollowObjectWriteRecord.NULL_FLOAT_BITS) {
       return Float.NaN;
     }
@@ -295,8 +296,8 @@ public double readFieldDouble(int ordinal, String field) {
   }
 
   public double readFieldDouble(Offset offset) {
-    offset.increment(8);
     long value = record.data.readLongBits(offset.get());
+    offset.increment(8);
     if (value == HollowObjectWriteRecord.NULL_DOUBLE_BITS) {
       return Double.NaN;
     }