Client code: Generate deprecations

[theHacker]

Client code generation now generates annotation and JavaDoc for deprecations, if enabled by addDeprecatedAnnotation.

Example:

extend type Query {
    
    foos(ids: [ID!] @deprecated(reason: "Use filters instead"), filters: FooFilters): [Foo!]!
}

Before	After

---

Hi there, 👋

This is my first contribution. I find createQueryClass() a very long and therefore unclear method. I did not dare to refactor here 😊 If you are fine with that, I would very much like to improve the code.

[srinivasankavitha]

We'll need to also update the generateJava task config to be able to use this setting.

[srinivasankavitha]

I would recommend checking that the generated class has the annotation rather than checking the entire code block to string match against. Same for the other tests.

[theHacker]

I want to assert that annotation and the javadoc look like expected.
Since both make up the upper part of the code, I rewrote with startsWith(). That way one you still easily see the empty that is expected to separate description and @deprecated inside the javadoc.

Is this acceptable? Or would you rather me to use methodSpec's annotations and javadoc for all cases?

[srinivasankavitha]

I guess we can leave it as is in this scenario, makes sense to me.

[theHacker]

Sorry about the late reply 😊

We'll need to also update the generateJava task config to be able to use this setting.

I don't understand that. I did not create that setting, but rather implemented its execution a bit further.
Do you mean GenerateJavaTask.kt, lines 145 and 211?

Or am I overlooking something? Glad for a hint into the right direction 😄

[srinivasankavitha]

Sorry about the late reply 😊

We'll need to also update the generateJava task config to be able to use this setting.

I don't understand that. I did not create that setting, but rather implemented its execution a bit further. Do you mean GenerateJavaTask.kt, lines 145 and 211?

Or am I overlooking something? Glad for a hint into the right direction 😄

Ah right, my bad. Sorry for the confusion. I see that we do indeed have it here: https://github.com/Netflix/dgs-codegen/blob/master/graphql-dgs-codegen-gradle/src/main/kotlin/com/netflix/graphql/dgs/codegen/gradle/GenerateJavaTask.kt#L145