Merge pull request #95 from elandau/bugfix/limit_gauge

Fix limit gauge not updating when using a PartitionedLimiter
Netflix · Jan 12, 2019 · eef9528 · eef9528
2 parents 32a58d3 + 97e1063
commit eef9528
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/...rrency-limits-core/src/main/java/com/netflix/concurrency/limits/limit/Gradient2Limit.java b/...rrency-limits-core/src/main/java/com/netflix/concurrency/limits/limit/Gradient2Limit.java
@@ -230,7 +230,7 @@ private Gradient2Limit(Builder builder) {
         this.minLimit = builder.minLimit;
         this.queueSize = builder.queueSize;
         this.smoothing = builder.smoothing;
-        this.shortRtt = new SingleMeasurement(); // new ExpAvgMeasurement(builder.shortWindow,10);
+        this.shortRtt = new SingleMeasurement();
         this.longRtt = new ExpAvgMeasurement(builder.longWindow, 10);
 
         this.longRttSampleListener = builder.registry.registerDistribution(MetricIds.MIN_RTT_NAME);

diff --git a/...core/src/main/java/com/netflix/concurrency/limits/limiter/AbstractPartitionedLimiter.java b/...core/src/main/java/com/netflix/concurrency/limits/limiter/AbstractPartitionedLimiter.java
@@ -269,6 +269,7 @@ private void releasePartition(Partition partition) {
 
     @Override
     protected void onNewLimit(int newLimit) {
+        super.onNewLimit(newLimit);
         partitions.forEach((name, partition) -> partition.updateLimit(newLimit));
     }