Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPDEV-109115] Depricated version of MacOS for Github Runner #707

Merged
merged 3 commits into from
Dec 10, 2024
Merged

[CPDEV-109115] Depricated version of MacOS for Github Runner #707

merged 3 commits into from
Dec 10, 2024

Conversation

pranavcracker
Copy link
Collaborator

@pranavcracker pranavcracker commented Dec 9, 2024 •
edited
Loading

Description

  • The exiting configuration is using MacOS-12 env for runner to run the Github actions. Since MacOS 12 is deprecated.

Fixes # (issue)
CPDEV-109115

Solution

  • Use MacOS-14 instead of MacOS-12 env for runner to run the Github actions.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • There is no breaking changes, or migration patch is provided
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

@pranavcracker pranavcracker marked this pull request as ready for review December 9, 2024 13:15
Imadzuma
Imadzuma reviewed Dec 9, 2024
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@pranavcracker pranavcracker self-assigned this Dec 10, 2024
@theboringstuff theboringstuff merged commit 84e0c7e into main Dec 10, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Imadzuma Imadzuma Imadzuma approved these changes

@theboringstuff theboringstuff Awaiting requested review from theboringstuff

@nikhil1697 nikhil1697 Awaiting requested review from nikhil1697

@DmitriiRabenok DmitriiRabenok Awaiting requested review from DmitriiRabenok

Assignees

@pranavcracker pranavcracker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pranavcracker @Imadzuma @theboringstuff