Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPDEV_105612] k8s_1.31_adoption #689

Merged
merged 19 commits into from
Oct 17, 2024
Merged

Conversation

nikhil1697
Copy link
Collaborator

@nikhil1697 nikhil1697 commented Sep 4, 2024

Description

Test Cases

TestCase 1

Steps:

  1. Kubemarine install -- kubernetesVersion: v1.31.1

Results:
Installation is successful

  1. Kubemarine upgrade from v1.30.3 to v1.31.1

Results:
Upgrade procedure is successful

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

Unit tests

Indicate new or changed unit tests and what they do, if any.

@nikhil1697
Copy link
Collaborator Author

nikhil1697 commented Sep 11, 2024

Added the changes from PR #644

@koryaga koryaga requested a review from Imadzuma September 11, 2024 08:13
@koryaga koryaga self-assigned this Sep 11, 2024
@koryaga koryaga self-requested a review September 11, 2024 08:13
@koryaga koryaga added the improvement New feature or request label Sep 11, 2024
@vlar0816
Copy link
Contributor

vlar0816 commented Oct 1, 2024

doesn't work, i don't see any changes in kubeadm-cm during and after upgrading to 1.31.0
also i don't see any debug messages for ControlPlaneKubeletLocalMode in debug.log

@koryaga koryaga marked this pull request as ready for review October 15, 2024 13:56
@koryaga koryaga changed the title [CPDEV_105612]_k8s_1.31_adoption [CPDEV_105612] k8s_1.31_adoption Oct 15, 2024
@koryaga koryaga requested a review from vlar0816 October 15, 2024 13:56
Copy link
Contributor

@vlar0816 vlar0816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The supported-versions table should also be updated - add v1.31.1

@koryaga koryaga requested a review from vlar0816 October 17, 2024 11:52
@koryaga koryaga merged commit cae5f5a into main Oct 17, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants