Error prompts on empty / invalid fields are not correctly displayed on Chrome with version below 119 #279 #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomaszDziezykNetcentric
requested review from
Lakshmishri,
SantiagoHomps-NC,
cogniSyb,
markovukiceviccn and
taimurCognizant
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
cogniSyb
changed the title
|
I checked your branch in Chrome 119 and Edge 119 on BrowserStack. The error text doesn’t show (no content placed in the DOM). On my Mac with Edge 119 I do get to see the error text :/ |
cogniSyb
approved these changes
Dec 7, 2023
markovukiceviccn
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #279
Test URLs: