Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource Gallery - Video in the video pop-up is cutoff #276 #277

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Resource Gallery - Video in the video pop-up is cutoff #276 #277

merged 3 commits into from
Dec 6, 2023

Conversation

cogniSyb
Copy link
Collaborator

@cogniSyb cogniSyb commented Dec 5, 2023

@cogniSyb cogniSyb added the Bugfix label Dec 5, 2023
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Dec 5, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Dec 5, 2023

Page Scores Audits Google
/pdp PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@cogniSyb cogniSyb marked this pull request as ready for review December 5, 2023 16:05
@cogniSyb cogniSyb merged commit 080974d into develop Dec 6, 2023
2 checks passed
cogniSyb added a commit that referenced this pull request Dec 12, 2023
@cogniSyb
Resource Gallery - Video in the video pop-up is cutoff #276 (#277)
718c58f 
* refactor icon usage
* remove redundant close button
* fix video size
cogniSyb added a commit that referenced this pull request Dec 12, 2023
@cogniSyb
Resource Gallery - Video in the video pop-up is cutoff #276 (#277)
6185628 
* refactor icon usage
* remove redundant close button
* fix video size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomaszDziezykNetcentric TomaszDziezykNetcentric TomaszDziezykNetcentric approved these changes

@markovukiceviccn markovukiceviccn markovukiceviccn approved these changes

Assignees
No one assigned
Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cogniSyb @TomaszDziezykNetcentric @markovukiceviccn