Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inpage navigation is in reversed order on Firefox #262 #265

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Inpage navigation is in reversed order on Firefox #262 #265

merged 4 commits into from
Nov 27, 2023

Conversation

cogniSyb
Copy link
Collaborator

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Nov 22, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Nov 22, 2023

Page Scores Audits Google
/pdp PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@Lakshmishri Lakshmishri changed the title Inpage navigation is in reversed order on Firefox #173 Inpage navigation is in reversed order on Firefox #262 Nov 23, 2023
@cogniSyb cogniSyb merged commit 45f8184 into develop Nov 27, 2023
2 checks passed
cogniSyb added a commit that referenced this pull request Dec 4, 2023
@cogniSyb
Inpage navigation is in reversed order on Firefox #262 (#265)
e7e0448 
* fix Firefox issue with sorting
* fix naming issues
* refactor focus state
* refactor button styles
cogniSyb added a commit that referenced this pull request Dec 12, 2023
@cogniSyb
Inpage navigation is in reversed order on Firefox #262 (#265)
1a5b133 
* fix Firefox issue with sorting
* fix naming issues
* refactor focus state
* refactor button styles
cogniSyb added a commit that referenced this pull request Dec 12, 2023
@cogniSyb
Inpage navigation is in reversed order on Firefox #262 (#265)
c46052e 
* fix Firefox issue with sorting
* fix naming issues
* refactor focus state
* refactor button styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lakshmishri Lakshmishri Lakshmishri approved these changes

@taimurCognizant taimurCognizant taimurCognizant approved these changes

@SantiagoHomps-NC SantiagoHomps-NC Awaiting requested review from SantiagoHomps-NC

@TomaszDziezykNetcentric TomaszDziezykNetcentric Awaiting requested review from TomaszDziezykNetcentric

@markovukiceviccn markovukiceviccn Awaiting requested review from markovukiceviccn

Assignees
No one assigned
Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cogniSyb @Lakshmishri @taimurCognizant