Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content carousel visual issues #258 #263

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Content carousel visual issues #258 #263

merged 3 commits into from
Nov 27, 2023

Conversation

Lakshmishri
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #258

Test URLs:

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Nov 22, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Nov 22, 2023

Page Scores Audits Google
/drafts/lakshmi/content-carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

cogniSyb
cogniSyb requested changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@cogniSyb cogniSyb left a comment •
edited by Lakshmishri
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency of focus states, could you also add border-radius: 4px to .v2-static-content-carousel__button?

Done

styles/styles.css Outdated Show resolved Hide resolved
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Nov 22, 2023

Page Scores Audits Google
/drafts/lakshmi/content-carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Nov 22, 2023

Page Scores Audits Google
/drafts/lakshmi/content-carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@cogniSyb cogniSyb changed the title 258 fix content carousel fixes Content carousel visual issues #258 Nov 27, 2023
@cogniSyb cogniSyb merged commit 2d35328 into develop Nov 27, 2023
2 checks passed
cogniSyb pushed a commit that referenced this pull request Dec 4, 2023
@Lakshmishri @cogniSyb
Content carousel visual issues #258 (#263)
06af513 
* fix disable functionality for previous/next buttons
* fix colour of gradient
* add border radius to button for focus state
cogniSyb pushed a commit that referenced this pull request Dec 12, 2023
@Lakshmishri @cogniSyb
Content carousel visual issues #258 (#263)
b97db14 
* fix disable functionality for previous/next buttons
* fix colour of gradient
* add border radius to button for focus state
cogniSyb pushed a commit that referenced this pull request Dec 12, 2023
@Lakshmishri @cogniSyb
Content carousel visual issues #258 (#263)
a4cbe21 
* fix disable functionality for previous/next buttons
* fix colour of gradient
* add border radius to button for focus state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cogniSyb cogniSyb cogniSyb approved these changes

@markovukiceviccn markovukiceviccn markovukiceviccn approved these changes

@taimurCognizant taimurCognizant taimurCognizant approved these changes

@TomaszDziezykNetcentric TomaszDziezykNetcentric Awaiting requested review from TomaszDziezykNetcentric

@SantiagoHomps-NC SantiagoHomps-NC Awaiting requested review from SantiagoHomps-NC

Assignees
No one assigned
Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lakshmishri @cogniSyb @markovukiceviccn @taimurCognizant