Social Block #67 #261
Merged
Social Block #67 #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
Lakshmishri
requested review from
TomaszDziezykNetcentric,
cogniSyb,
SantiagoHomps-NC,
markovukiceviccn and
taimurCognizant
cogniSyb
requested changes
Nov 21, 2023
|
cogniSyb
requested changes
Nov 22, 2023
|
taimurCognizant
requested changes
Nov 22, 2023
|
@Lakshmishri as per design, position the tooltip TOP CENTERED for mobile devices |
|
@Lakshmishri I just had the meeting with the agency. Apparently this block won’t be placed in a section with black/gray background. Rather we should add variants on the block level here. This means that the black variant should be as designed |
|
cogniSyb
approved these changes
Nov 23, 2023
taimurCognizant
requested changes
Nov 24, 2023
|
taimurCognizant
approved these changes
Nov 27, 2023
cogniSyb
pushed a commit
that referenced
this pull request
Dec 4, 2023
cogniSyb
pushed a commit
that referenced
this pull request
Dec 12, 2023
cogniSyb
pushed a commit
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #67
Test URLs: