Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solutions Block #63 #95

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Solutions Block #63 #95

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6786af0
#63 - Solutions block styles
markovukiceviccn Sep 28, 2023
8d2de25
#63 - Adjust media queries nesting, add pretitle class, change font f…
markovukiceviccn Oct 4, 2023
e9ca704
#63 - refactor columns v2, reorganize media queries
markovukiceviccn Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions blocks/v2-solutions/v2-solutions.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
.v2-solutions-container {
display: flex;
flex-direction: column;

@media (min-width: 744px) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you refactor the CSS nesting? There’s not enough support for it in Firefox.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Media queries nesting adjusted.

flex-direction: row;
}
}

.v2-solutions-wrapper {
flex-basis: 33.33%;
}

.v2-solutions {
@media (min-width: 1200px) {
padding-right: 16px;
}
}

.v2-solutions-container.v2-cards-container {
max-width: var(--wrapper-width);
margin: auto;
}

.v2-solutions-container.v2-cards-container .v2-cards-wrapper {
flex-basis: 66.66%;
}

.v2-solutions-container.v2-cards-container .v2-cards__card-item {
width: 100%;

@media (min-width: 744px) {
max-width: calc((100% - 48px) / 2);
}
}


.v2-solutions h1 {
font: normal var(--headline-1-font-size)/1.15 var(--ff-headline-medium);
margin-top: 12px;

@media (min-width: 1200px) {
font-size: var(--headline-1-font-size);
}
}

.v2-solutions h1 + p {
font: normal var(--body-font-size-s)/1.5 var(--ff-body);
}

.v2-solutions > div > div > p:first-child {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a shared style. Can you reuse code what’s in the Volvo repository? It would replace current code in another block as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now changed and use adjustPretitle function.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you then refactor v2-columns.js as well? When the pretitle styling is put in styles.css, then code could be removed from v2-columns.css

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

font: normal var(--accent-2-font-size)/1.2 var(--ff-accents);
}

.v2-solutions .button.button--primary {
font-family: var(--ff-subheadings-medium);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove, and please fix https://github.com/Netcentric/vg-macktrucks-com-rd/blob/main/styles/styles.css#L868 instead :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Font family is now changed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant changing the standard font-family for buttons in styles.css (for redesign)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now done

}


Empty file added blocks/v2-solutions/v2-solutions.js
View file
Open in desktop
Empty file.