Columns block #65
Columns block #65
Conversation
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
SantiagoHomps-NC
requested review from
kesiah,
Lakshmishri,
manuel-vara,
TomaszDziezykNetcentric,
cogniSyb,
avinashNChavan and
markovukiceviccn
|
blocks/v2-columns/v2-columns.css
Outdated
| align-items: center; | ||
| } | ||
|
|
||
| .v2-columns .v2-columns-image, |
There was a problem hiding this comment.
Avoid unnecessary specificity, for example this can be changed to: .v2-columns-image, .v2-columns-content
Check all the document ;)
blocks/v2-columns/v2-columns.css
Outdated
| margin: 0; | ||
| } | ||
|
|
||
| .v2-columns .v2-columns-content h1.v2-columns-content__headline { |
There was a problem hiding this comment.
Avoid using tags h1, p in CSS as much as possible.
What will happen if the editor decides to use h2 instead of h1? The styles won't be applied. But if you just use the class, any tag containing the class will be styled.
|
|
|
|
|
|
you're right... the class is not necessary. I also changed the styling to the buttons so that if there are more they get a little margin |
|
|
V2 columns now gathers all the text from all the columns and put it inside one column. For the block: |
|
There was a problem hiding this comment.
In mobile, I'm not sure about centring the items while other components will be left aligned and using 100% of the viewport width. @cogniSyb what should we do?
In desktop, the width of the column is not the same as the rest of the components. They should be aligned.
@cogniSyb @Lakshmishri should the order of the items in the columns be the same always in mobile? I mean, image + text? Currently, depending on how they are introduced by the editor, we show image + text or text + image, should we align them both in mobile or not?
|
I think we should do the same as the testimonial block: text, then image |
|
done |
|
|
Done. The container is 1040px. Column max width is 512px (with aspect ratio 1:1 for image and text column is centered). |
Fix #41
Test URLs: