Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linting dependencies and configuration #20

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .stylelintrc.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
{
"extends": ["stylelint-config-standard"]
"extends": ["stylelint-config-standard"],
"rules": {
"declaration-block-no-redundant-longhand-properties": [
true,
{
"ignoreShorthands": ["inset"]
}
],
"media-feature-range-notation": "prefix",
"selector-class-pattern": [
"^[a-z]([-]?[a-z0-9]+)*(__[a-z0-9]([-]?[a-z0-9]+)*)?(--[a-z0-9]([-|_]?[a-z0-9]+)*)?$",
{
"message": "Expected class \"%s\" to be in kebab-case or BEM-style naming."
}
]
}
}
2 changes: 1 addition & 1 deletion blocks/hero/hero.css
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* stylelint-disable */
/* stylelint-disable no-descending-specificity */

/* auto and non-auto block shared styles */
:root {
Expand Down
1 change: 0 additions & 1 deletion blocks/hotspots/hotspots.css
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,6 @@
right: 30px;
}

/* stylelint-disable-next-line max-line-length */
.hotspots-container .hotspot-layover .hotspot-layover-box .hotspot-layover-controls .hotspot-layover-button:first-child {
border-right: 1px solid #222;
}
Expand Down
1 change: 0 additions & 1 deletion blocks/v2-hero/v2-hero.css
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* stylelint-disable selector-class-pattern */
.v2-hero {
/* height of the hero block is set in main style to prevent CLS */
position: relative;
Expand Down
1 change: 0 additions & 1 deletion common/modal/modal-component.css
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@
}

.modal-content.modal-form .eloqua-form .elq-form input[type="checkbox"],
/* stylelint-disable-next-line max-line-length */
.modal-content.modal-form .eloqua-form .single-checkbox-row input ~ label.checkbox-aligned.elq-item-label::before {
background-color: transparent;
}
Expand Down
6,635 changes: 690 additions & 5,945 deletions package-lock.json

Large diffs are not rendered by default.

16 changes: 8 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,17 @@
},
"homepage": "https://github.com/adobe/helix-project-boilerplate#readme",
"devDependencies": {
"@babel/core": "7.21.0",
"@babel/eslint-parser": "7.19.1",
"chai": "4.3.7",
"eslint": "8.35.0",
"eslint-config-airbnb-base": "15.0.0",
"eslint-plugin-import": "2.27.5",
"@babel/core": "7.22.10",
"@babel/eslint-parser": "7.22.10",
"@esm-bundle/chai": "4.3.4-fix.0",
"@web/test-runner": "0.15.1",
"@web/test-runner-commands": "0.6.5",
"chai": "4.3.7",
"eslint": "8.47.0",
"eslint-config-airbnb-base": "15.0.0",
"eslint-plugin-import": "2.28.0",
"sinon": "15.0.1",
"stylelint": "15.7.0",
"stylelint-config-standard": "30.0.1"
"stylelint": "15.10.2",
"stylelint-config-standard": "34.0.0"
}
}
1 change: 0 additions & 1 deletion styles/lazy-styles.css
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* stylelint-disable */
/* below the fold CSS goes here */

/* Headings */
Expand Down
2 changes: 0 additions & 2 deletions styles/styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
src: local("Arial");
ascent-override: 93.75%;
descent-override: 6.25%;
/* stylelint-disable-next-line number-no-trailing-zeros */
line-gap-override: 0.00%;
/* stylelint-disable-next-line number-no-trailing-zeros */
size-adjust: 100.00%;
}

Expand Down
2 changes: 0 additions & 2 deletions templates/body-builder-news/body-builder-news.css
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* stylelint-disable indentation */
/* stylelint-disable-next-line comment-empty-line-before */
/* body builder news styling */
.body-builder-news main {
background-color: var(--color-white);
Expand Down