-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON File Creation for "All Trucks" filter #102 #123
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
@manuel-vara With this we’re passing along the page title and page description. We need for the All Trucks page only the model name. Would we achieve that with 1) stripping content that follows a character – like the vertical bar in Volvo Trucks Magazine or 2) add a separate field here? |
Shouldn’t we have two images for the All Trucks page? |
Good point, I guess this is to be able to add the effect on hovering ecah truck, right? we could add another metadata element named |
We can remove the title from the index, indeed, as it's not required but I left it in case Marko needs it to compose the All Trucks page. We would need to fetch the following metadata from the PDP Page of each truck:
It looks like 2 images elements would be handy as well (regular and on-hover) |
Closing as we chose a different solution |
Fix #102
Updated helix-query.yaml file with new index to get additional metadata elements from PDP pages:
Test URLs: