Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON File Creation for "All Trucks" filter #102 #123

Closed
wants to merge 2 commits into from

Conversation

manuel-vara
Copy link
Collaborator

Fix #102

Updated helix-query.yaml file with new index to get additional metadata elements from PDP pages:

image

Test URLs:

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Oct 18, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Oct 18, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Oct 18, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@cogniSyb
Copy link
Collaborator

@manuel-vara With this we’re passing along the page title and page description. We need for the All Trucks page only the model name. Would we achieve that with 1) stripping content that follows a character – like the vertical bar in Volvo Trucks Magazine or 2) add a separate field here?

@cogniSyb
Copy link
Collaborator

Shouldn’t we have two images for the All Trucks page?

@manuel-vara
Copy link
Collaborator Author

Shouldn’t we have two images for the All Trucks page?

Good point, I guess this is to be able to add the effect on hovering ecah truck, right? we could add another metadata element named hover image or something similar, where we can place that image.

@manuel-vara
Copy link
Collaborator Author

@manuel-vara With this we’re passing along the page title and page description. We need for the All Trucks page only the model name. Would we achieve that with 1) stripping content that follows a character – like the vertical bar in Volvo Trucks Magazine or 2) add a separate field here?

We can remove the title from the index, indeed, as it's not required but I left it in case Marko needs it to compose the All Trucks page.
According to issue #102

We would need to fetch the following metadata from the PDP Page of each truck:

  • Model
  • Segment
  • Description
  • Builder (instead of boolean I used a 'yes', and we could use a 'no' or no Builder element when this is not needed)

It looks like 2 images elements would be handy as well (regular and on-hover)
Should I add the additional image to PDP metadata?

@DanielaPedrochevd DanielaPedrochevd added this to the MT PDP milestone Oct 31, 2023
@cogniSyb
Copy link
Collaborator

Closing as we chose a different solution

@cogniSyb cogniSyb closed this Oct 31, 2023
@cogniSyb cogniSyb added the Wontfix This will not be worked on label Nov 7, 2023
@cogniSyb cogniSyb changed the title 102 index all trucks JSON File Creation for "All Trucks" filter. #102 Nov 7, 2023
@cogniSyb cogniSyb changed the title JSON File Creation for "All Trucks" filter. #102 JSON File Creation for "All Trucks" filter #102 Nov 7, 2023
@WendyKruger WendyKruger removed this from the MT PDP milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON File Creation for "All Trucks" filter.
5 participants