Skip to content

Commit

Permalink
comments addressed
Browse files Browse the repository at this point in the history
  • Loading branch information
santi-homps committed Feb 8, 2024
1 parent af6f0d8 commit 09d478f
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 12 deletions.
29 changes: 20 additions & 9 deletions blocks/v2-resources/v2-resources.css
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,21 @@

.v2-resources__heading {
font-family: var(--ff-headline-medium);
margin: 0;
margin: 0 0 8px;
}

.v2-resources__subtitle {
margin: 40px 0 0;
.v2-resources__content {
display: flex;
flex-direction: column;
gap: 8px;
}

.v2-resources__text {
margin: 8px 0 16px;
.v2-resources__content p {
margin: 0;
}

.v2-resources__subtitle {
margin: 32px 0 0;
}

a.v2-resources__link {
Expand All @@ -29,6 +35,7 @@ a.v2-resources__link {
letter-spacing: 1.12px;
line-height: var(--button-line-height);
border-bottom: 1px solid transparent;
margin-top: 8px;
}

a.v2-resources__link:hover {
Expand All @@ -44,7 +51,7 @@ a.v2-resources__link:hover {
bottom: 0;
}

@media (min-width: 768px) {
@media (min-width: 744px) {
.section.v2-resources-container {
padding: 0 0 80px;
}
Expand All @@ -59,7 +66,11 @@ a.v2-resources__link:hover {
}

.v2-resources__header {
width: 40vw;
width: 40%;
}

.v2-resources__heading {
margin: 0;
}

.v2-resources__content .v2-resources__subtitle:first-of-type {
Expand All @@ -75,8 +86,8 @@ a.v2-resources__link:hover {
@media (min-width: 1200px) {
.v2-resources-container.section--background-with-dots::after {
height: 42%;
width: 17%;
left: 9%;
width: 25vw;
left: 5%;
}

.section.v2-resources-container .v2-resources-wrapper {
Expand Down
4 changes: 1 addition & 3 deletions blocks/v2-resources/v2-resources.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@ export default async function decorate(block) {
contentElmts.forEach((el, idx) => {
const tagName = el.tagName.toLowerCase();
const isButton = [...el.classList].includes('button-container');
if (tagName === 'p' && !isButton) {
el.classList.add(`${blockName}__text`);
} else if (tagName === 'p' && isButton) {
if (tagName === 'p' && isButton) {
const link = el.querySelector('a');
link.classList.add(`${blockName}__link`);
link.classList.remove('button--primary', 'button');
Expand Down

0 comments on commit 09d478f

Please sign in to comment.