Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#97 add npm i test for windows #98

Merged
merged 7 commits into from
Oct 9, 2023
Merged

#97 add npm i test for windows #98

merged 7 commits into from
Oct 9, 2023

Conversation

easingthemes
Copy link
Member

@easingthemes easingthemes commented Oct 9, 2023 •
edited by FelipeSimoes
Loading

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed.

@FelipeSimoes
Copy link
Contributor

Update build command, since tests asserting will always fail since the output will always differ on break lines and whitespaces in Windows OS. but NPM install should be run in both OS

@FelipeSimoes FelipeSimoes merged commit 5e7bc7b into main Oct 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelipeSimoes FelipeSimoes FelipeSimoes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@easingthemes @FelipeSimoes