Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to webpack 5 #73

Merged
merged 24 commits into from
Oct 19, 2023
Merged

Upgrade to webpack 5 #73

merged 24 commits into from
Oct 19, 2023

Conversation

juantxokupul
Copy link
Member

@juantxokupul juantxokupul commented Jul 15, 2022 •
edited by FelipeSimoes
Loading

Description

Upgrade to webpack 5

Related Issue

Fixes #31

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed.

@juantxokupul juantxokupul self-assigned this Jul 15, 2022
@juantxokupul juantxokupul added the enhancement New feature or request label Jul 15, 2022
@raohmaru raohmaru self-requested a review July 21, 2022 08:55
@raohmaru
Copy link
Contributor

Please wait until PR #75 is merged, it contains new test cases to test the build.

@easingthemes
Copy link
Member

easingthemes commented Jul 22, 2022 •
edited
Loading

This looks to easy to be truth :).
We have delayed upgrade for almost a year because we expected extremely big changes.

easingthemes
easingthemes requested changes Jul 22, 2022
View reviewed changes
Copy link
Member

@easingthemes easingthemes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. It should be a breaking change, since you can't know how users extended this library. Eg we are using some webpack/babel plugins by extending .febuild and we need to update (or even totally replace) them since they are not compatible with webpack v5.
  2. It should be tested, as @raohmaru mentioned

@juantxokupul juantxokupul removed their assignment Aug 4, 2022
@juantxokupul
Copy link
Member Author

Leaving this unassigned since currently I don't find time to work on this.

@raohmaru
Copy link
Contributor

raohmaru commented Jun 7, 2023

Does it contain any breaking change? If so it should be detailed in the readme.

@quicoto
Copy link
Member

quicoto commented Jun 7, 2023

Leaving this unassigned since currently I don't find time to work on this.

I think so, we need to push a commit with "BREAKING CHANGE: " so the build will trigger a major release.

@FelipeSimoes FelipeSimoes self-assigned this Oct 16, 2023
@FelipeSimoes FelipeSimoes marked this pull request as draft October 16, 2023 07:42
@FelipeSimoes FelipeSimoes marked this pull request as ready for review October 18, 2023 17:05
@FelipeSimoes FelipeSimoes removed the request for review from raohmaru October 18, 2023 17:15
@FelipeSimoes FelipeSimoes merged commit cb9ed20 into main Oct 19, 2023
6 checks passed
@easingthemes easingthemes deleted the feature/#31-upgrade-to-webpack-5 branch December 19, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelipeSimoes FelipeSimoes FelipeSimoes left review comments

@quicoto quicoto quicoto approved these changes

@easingthemes easingthemes easingthemes approved these changes

Assignees

@FelipeSimoes FelipeSimoes

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to webpack 5
5 participants
@juantxokupul @raohmaru @easingthemes @quicoto @FelipeSimoes