336 metadata content animation #400
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
Victor-AcostaCNC
requested review from
alexnerdrumhansen and
nc-andreashaller
| }); | ||
| }; | ||
|
|
||
| const observer = new IntersectionObserver(applyAnimation, { threshold: 0.3 }); |
There was a problem hiding this comment.
looking at the code I had an additional thought: if we overwrite the animation in a section don't we have to remove all those listeners?
| }); | ||
| }; | ||
|
|
||
| const observer = new IntersectionObserver(applyAnimation, { threshold: 0.3 }); |
There was a problem hiding this comment.
@tomasznetcentric please have a look if all those listeners and observers are ok to use and the most efficient way to do it
There was a problem hiding this comment.
@nc-andreashaller The listeners and observers are fine so far. We could do just some improvements in terms of readability and organization. But its okay.
| }); | ||
| }; | ||
|
|
||
| const observer = new IntersectionObserver(applyAnimation, { threshold: 0.3 }); |
There was a problem hiding this comment.
@nc-andreashaller The listeners and observers are fine so far. We could do just some improvements in terms of readability and organization. But its okay.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #336
Test URLs:
To test this add a column with the key "animated" both on metadata and section metadata.
Values can be UP, LEFT, RIGHT, DOWN and NONE
To add animation on a general level:
To add animation on a section level:
