#281 improve some code smell & more

[jonatan-lledo-netcentric]

There is always room for improvement, but this is just one step to refactoring the current main scripts: scripts.js and lib-franklin.js (still a work in progress, but the current work can be added and retaken later to continue with the refactor)

Fix #281

Test URLs:

• Before: https://main--cn-website--netcentric.hlx.page/
• After: https://281-improverefactor-initial-code--cn-website--netcentric.hlx.page/

[aem-code-sync]

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

• Re-run PSI Checks

[aem-code-sync]

Page	Score	PSI Audit	Google
/

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

• Re-run PSI Checks

[aem-code-sync]

Page	Scores	Audits	Google
/

[jonatan-lledo-netcentric]

a colleague of my team reminded me that if Adobe updates lib-franklin, all changes in lib-franklin.js will be lost, so maybe it is better if in the changes that I made, we can revoke them, but not the ones in scripts.js, WDYT @tomasznetcentric

[tomasznetcentric]

a colleague of my team reminded me that if Adobe updates lib-franklin, all changes in lib-franklin.js will be lost, so maybe it is better if in the changes that I made, we can revoke them, but not the ones in scripts.js, WDYT @tomasznetcentric

@jonatan-lledo-netcentric but make this refactoring sense outside of the lib-franklin.js ?

[jonatan-lledo-netcentric]

a colleague of my team reminded me that if Adobe updates lib-franklin, all changes in lib-franklin.js will be lost, so maybe it is better if in the changes that I made, we can revoke them, but not the ones in scripts.js, WDYT @tomasznetcentric

@jonatan-lledo-netcentric but make this refactoring sense outside of the lib-franklin.js ?

not necessarily, at that moment was a matter of seeing if the code could be improved and I started with the core scripts. but currently, there are enough open issues to work with more important than this one. WDYT?

[nc-andreashaller]

a colleague of my team reminded me that if Adobe updates lib-franklin, all changes in lib-franklin.js will be lost, so maybe it is better if in the changes that I made, we can revoke them, but not the ones in scripts.js, WDYT @tomasznetcentric

@jonatan-lledo-netcentric but make this refactoring sense outside of the lib-franklin.js ?

not necessarily, at that moment was a matter of seeing if the code could be improved and I started with the core scripts. but currently, there are enough open issues to work with more important than this one. WDYT?

Just to clarify: lib-franklin.js will not be auto updated by Adobe, we always have to pull changes manually from the boilerplate if we want to update. Having that said we should avoid making changes which are not functional to minimise effort if we want to take over changes.