Skip to content

Commit

Permalink
Revert proxy change (#579)
Browse files Browse the repository at this point in the history
* Revert "Optionally pass in `proxy` parameter to Savon (#548)"

This reverts commit 7490788.

* Restore history to state of master

* Updates history with current change

* Revert test file back to state of master

* Random comment change to get another build

* Reverting comment test
  • Loading branch information
andrewdicken-stripe committed Aug 14, 2023
1 parent a23f1f5 commit 016aab0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions HISTORY.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
### Added

### Fixed
* Revert recent proxy changes which breaks proxy usage by @andrewdicken-stripe in https://github.com/NetSweet/netsuite/pull/579

### Breaking Changes

Expand Down
2 changes: 1 addition & 1 deletion lib/netsuite/configuration.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ def connection(params={}, credentials={}, soap_header_extra_info={})
logger: logger,
log_level: log_level,
log: !silent, # turn off logging entirely if configured
proxy: proxy,
}.update(params))
client.globals.proxy(proxy) if proxy
cache_wsdl(client)
return client
end
Expand Down

0 comments on commit 016aab0

Please sign in to comment.