-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework app cast handling; add JSON compatibility; add AppCastItem.Channel; built-in channel-based app cast filter implementation #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't test everywhere due to hardcoded XML but does some good sanity checks which is good
Deadpikle
changed the title
WIP: Rework app cast handling
WIP: Rework app cast handling; add JSON compatibility
Jul 30, 2024
Have shuffled the API a little bit for more async work, still WIP as things need renaming and potentially more moving around
This reverts commit b096766.
Allow filtering via ChannelAppCastFilter
Deadpikle
changed the title
WIP: Rework app cast handling; add JSON compatibility; built-in channel-based app cast filter implementation
WIP: Rework app cast handling; add JSON compatibility; add AppCastItem.Channel; built-in channel-based app cast filter implementation
Aug 6, 2024
Deadpikle
changed the title
WIP: Rework app cast handling; add JSON compatibility; add AppCastItem.Channel; built-in channel-based app cast filter implementation
Rework app cast handling; add JSON compatibility; add AppCastItem.Channel; built-in channel-based app cast filter implementation
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks app cast handling by separating out some logic of things, adjust return parameters, and more. Also adds JSON app cast handling and
ChannelAppCastFilter
class.DownloadAndParse
(split into separate download and parse functions?),GetAvailableUpdates
(consider rename or differentFilteredAppCastItems
property or similar for greater clarity on what is happening)AppCastHandler
entirely and breaking out its functionality to different objects that are more specific (filtering to a filter object, etc.)AppCastHandler
should hold an actualAppCast
object and, if not, who should. (What state is held where, in other words?)SparkleUpdater
keep a most recent parsed cached version for safe keeping but otherwise not hang onto itIAppCastDataDownloader.DownloadAndGetAppCastDataAsync
IAppCastGenerator
)signature
enclosure title in XML output to app cast maker, etc.ChannelAppCastFilter
AppCastItem
,AppCast
, etc.Sparkle
output (Enhance NetSparkleUpdater app cast compatibility with Sparkle app casts #275), including applicable changes to app cast generator (this should be fairly easy to do now with another option or two on both theSparkleUpdater
end and the app cast generator end -- basically, let the user determine what the title forsignature
is in xml app casts)<sparkle:channel>
for channels outside ofVersion
property (incl. tests, app cast gen, usage inChannelAppCastFilter
)Closes #275
Closes #598
Closes #599