-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for NetSparkle trimming (Core DLL, Avalonia) #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes semver data not loading
Use AssemblyInformationalVersionAttribute attribute
Trims properly, and so does the old version, actually. However, non-trimmed is still very large.
Deadpikle
changed the title
[WIP] Feature/trimming support
Initial support for NetSparkle trimming (Core DLL, Avalonia)
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #585.
Includes some things we'll want even without full trimming support (if it comes to that).
Notes:
<IsTrimmable>true</IsTrimmable>
and<TrimMode>partial</TrimMode>
toNetSparkle.csproj
IAssemblyAccessor
:AsmResolverAccessor
IAssemblyAccessor
so users know where stuff is coming fromTrimMode
tofull
trims BouncyCastle, as does not specifyingTrimMode
at all. HOWEVER, nuget pack doesn't work/trim, so...maybe it is just time to replace BouncyCastle...).dotnet pack
just fails when trimming is on.)