-
Notifications
You must be signed in to change notification settings - Fork 43
Feature/migratenetmq4 samples #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As someone who works on the Visual Studio project system, I love to see this kind of migration. Thanks!
A few comments here for things to fix up before we can merge this.
...liability (Freelance Pattern)/Model One/Freelance.ModelOne.Client/Properties/AssemblyInfo.cs
Show resolved
Hide resolved
src/Majordomo/MDPClientAsyncExample/MDPClientAsyncExample.csproj
Outdated
Show resolved
Hide resolved
- added Build props file for solution - fixed framework supported versions - remove duplicated netcoreapp3.1
fixup original copyright information from assemblyinfo
- samples Client. both Server and Server2 versions
@drewnoakes i think it's for review now, but i'm didn't port two last samples Multitheading and LazyPirate.Client2 those two still broked:
|
No description provided.