Skip to content

Feature/migratenetmq4 samples #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

drr00t
Copy link

@drr00t drr00t commented Sep 4, 2021

No description provided.

@drr00t drr00t changed the title Feature/migratenetmq4 Feature/migratenetmq4 samples Sep 4, 2021
Copy link
Member

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As someone who works on the Visual Studio project system, I love to see this kind of migration. Thanks!

A few comments here for things to fix up before we can merge this.

- added Build props file for solution
- fixed framework supported versions
- remove duplicated netcoreapp3.1
- update Titanic Pattern examples
- removed empty properties directory from MPDClientAsyncExample
@drr00t drr00t marked this pull request as draft September 6, 2021 19:48
@drr00t
Copy link
Author

drr00t commented Sep 7, 2021

@drewnoakes i think it's for review now, but i'm didn't port two last samples Multitheading and LazyPirate.Client2 those two still broked:

  • Multitheading/Multithreaded Service: need more work because of changes in NetMQQueue implementation
  • Pirate Pattern/LazyPirate.Client2: need more work because of changes in the style of pub-sub implementation.

@drr00t drr00t marked this pull request as ready for review September 7, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants