Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle failure in nkpacket_transport_tcp:start_link #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mritalian
Copy link

If a new connection fails to start for whatever reason, without this catch, it will tear down the entire service, including all other established connections.

If a new connection fails to start for whatever reason, without this catch, it will tear down the entire service, including all other established connections.

Change-Id: I9d109340ddf7818411dcfaec4452df85c389a82a
@kalta
Copy link
Member

kalta commented Oct 30, 2020

Hi, thank you. I think it make sense. Could you please send it again against last version to avoid conflicts? I am not using this code now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants