Skip to content
This repository was archived by the owner on Jan 3, 2023. It is now read-only.

Sarkars/flib ngenc compute #529

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Handle error (when gdef not found)
sayantan-nervana committed Apr 18, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit b3e57b047fb613e433210857d6caf8851f35d141
5 changes: 4 additions & 1 deletion src/ngraph_encapsulate_op.cc
Original file line number Diff line number Diff line change
@@ -101,7 +101,10 @@ class NGraphEncapsulateOp : public OpKernel {
const FunctionDef* fdef =
flib.Find("Enc_" + to_string(m_ngraph_cluster) + "_native_segment");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the node name (eg. ngraph_cluster_251) instead of this "Enc_" + to_string(m_ngraph_cluster)" ?

if (fdef == nullptr) {
// TODO: error
OP_REQUIRES_OK(
ctx, errors::Internal(
"Did not find graphdef for encapsulate ", m_ngraph_cluster,
" in NGraphClusterManager or function library"));
}
// TODO: how to convert from functiondef to graphdef. Anything easier?
FunctionBody* fnbody;