Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getEnvInfoSync should not be promisified #13959

Merged
merged 4 commits into from
Jul 24, 2023
Merged

fix: getEnvInfoSync should not be promisified #13959

merged 4 commits into from
Jul 24, 2023

Conversation

wenfangdu
Copy link
Contributor

这个 PR 是什么类型? (至少选择一个)

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）
  • 鸿蒙（harmony）

@taro-bot2
Copy link

taro-bot2 bot commented Jun 5, 2023

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献！🌷🌷🌷

一般 PR 会在一到两周内进行 review，成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间，所以请遵循以下规范，协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景（非常重要，例如解决了什么问题，该问题如何复现等）
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通，请加入 Taro 开发者微信群：

@Chen-jj
Copy link
Contributor

Chen-jj commented Jun 7, 2023

@wenfangdu 麻烦更新一下 snapshot，好像 typings 也要更新下？

@wenfangdu wenfangdu marked this pull request as draft June 7, 2023 04:44
@wenfangdu wenfangdu marked this pull request as ready for review June 27, 2023 06:13
@wenfangdu
Copy link
Contributor Author

@Chen-jj 大佬，类型已更新，updateSnapshot 跑不通，你来更新吧

@taro-bot2 taro-bot2 bot mentioned this pull request Jul 1, 2023
Closed
@Chen-jj Chen-jj merged commit 312ba95 into NervJS:next Jul 24, 2023
4 checks passed
yechunxi pushed a commit to yechunxi/taro that referenced this pull request Aug 4, 2023
@wenfangdu @xuanzebin @yechunxi
fix: getEnvInfoSync should not be promisified (NervJS#13959)
438be99 
* fix: `getEnvInfoSync` should not be promisified

* feat: added getEnvInfoSync typings

* test(snapshot): 更新测试快照

---------

Co-authored-by: xuanzebin <[email protected]>
Co-authored-by: xuanzebin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chen-jj Chen-jj Chen-jj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Taro.getEnvInfoSync() 不支持字节小程序
3 participants
@wenfangdu @Chen-jj @xuanzebin